Skip to content

Use SsdpServiceInfo for SOURCE_SSDP tests (part 4)#60339

Merged
bdraco merged 10 commits intohome-assistant:devfrom
epenet:ssdp-tests-part4
Nov 25, 2021
Merged

Use SsdpServiceInfo for SOURCE_SSDP tests (part 4)#60339
bdraco merged 10 commits intohome-assistant:devfrom
epenet:ssdp-tests-part4

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 25, 2021

Proposed change

Use SsdpServiceInfo for SOURCE_SSDP tests (part 4) as preliminary work for #59931.

They are split out from part 1/2/3 because the __iter__ method needs to be implemented in SsdpServiceInfo (at least temporarily)

Requires parts 2 and 3 to be merged: #60322, #60334
Also needs #60340

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @StevenLooman, @ehendrix23, mind taking a look at this pull request as it has been labeled with an integration (upnp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @heythisisnate, @kit-klein, mind taking a look at this pull request as it has been labeled with an integration (konnected) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, @frenck, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @leofig-rj, mind taking a look at this pull request as it has been labeled with an integration (wilight) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @ol-iver, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet marked this pull request as draft November 25, 2021 15:08
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 25, 2021

This also needs #60340 to be merged beforehand.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 25, 2021

Needs a rebase

@epenet epenet marked this pull request as ready for review November 25, 2021 18:54
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 25, 2021

This should be the last batch for the preliminary work of #59931

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 25, 2021

Looks like it needs a tweak
Warning: homeassistant/components/ssdp/__init__.py:168:1: D205 1 blank line required between summary line and description

return getattr(self, name)
return self.upnp.get(name, default)

def __iter__(self) -> Iterator[str]:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for in calls like in konnected:

if not any(
name in discovery_info[ATTR_UPNP_MODEL_NAME]
for name in KONN_PANEL_MODEL_NAMES
):

As in https://github.com/home-assistant/core/pull/60334/files#r756924593, this might need to be added to zeroconf/dhcp/usb/mqtt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should since its a temp measure and the goal is to avoid a breaking change

@epenet epenet changed the title Use SsdpServiceInfo for SOURCE_SSDP tests (part 4) Use SsdpServiceInfo for SOURCE_SSDP tests (part 4) Nov 25, 2021
@bdraco bdraco merged commit 22bdd38 into home-assistant:dev Nov 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
@epenet epenet deleted the ssdp-tests-part4 branch November 29, 2021 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants