Use SsdpServiceInfo for SOURCE_SSDP tests (part 4)#60339
Use SsdpServiceInfo for SOURCE_SSDP tests (part 4)#60339bdraco merged 10 commits intohome-assistant:devfrom
Conversation
|
Hey there @StevenLooman, @ehendrix23, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @heythisisnate, @kit-klein, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @balloob, @frenck, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @leofig-rj, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @ol-iver, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( |
|
This also needs #60340 to be merged beforehand. |
|
Needs a rebase |
44f3495 to
4bd4229
Compare
|
This should be the last batch for the preliminary work of #59931 |
|
Looks like it needs a tweak |
| return getattr(self, name) | ||
| return self.upnp.get(name, default) | ||
|
|
||
| def __iter__(self) -> Iterator[str]: |
There was a problem hiding this comment.
This is required for in calls like in konnected:
core/homeassistant/components/konnected/config_flow.py
Lines 253 to 256 in fb909ec
As in https://github.com/home-assistant/core/pull/60334/files#r756924593, this might need to be added to zeroconf/dhcp/usb/mqtt
There was a problem hiding this comment.
We probably should since its a temp measure and the goal is to avoid a breaking change
SsdpServiceInfo for SOURCE_SSDP tests (part 4)
Proposed change
Use
SsdpServiceInfoforSOURCE_SSDPtests (part 4) as preliminary work for #59931.They are split out from part 1/2/3 because the
__iter__method needs to be implemented inSsdpServiceInfo(at least temporarily)Requires parts 2 and 3 to be merged: #60322, #60334Also needs #60340Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: