Skip to content

Use SsdpServiceInfo for ssdp tests (part 1)#60320

Merged
frenck merged 15 commits intohome-assistant:devfrom
epenet:SsdpServiceInfo-a-f
Nov 25, 2021
Merged

Use SsdpServiceInfo for ssdp tests (part 1)#60320
frenck merged 15 commits intohome-assistant:devfrom
epenet:SsdpServiceInfo-a-f

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 25, 2021

Proposed change

Use SsdpServiceInfo for SOURCE_SSDP tests (part 1) as preliminary work for #59931.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • [x ] There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 25, 2021

@frenck this one is for you: CI is failing with multiple non-core components (pylint and mypy)

Run . venv/bin/activate
************* Module homeassistant/components/{axis,harmony,heos,isy994,nanoleaf,octoprint,roku,songpal,synology_dsm,unifi,yeelight}
Error: homeassistant/components/{axis,harmony,heos,isy994,nanoleaf,octoprint,roku,songpal,synology_dsm,unifi,yeelight}:1:0: F0001: No module named homeassistant/components/{axis,harmony,heos,isy994,nanoleaf,octoprint,roku,songpal,synology_dsm,unifi,yeelight} (fatal)
Error: Process completed with exit code 1.
Run . venv/bin/activate
mypy: can't read file 'homeassistant/components/{axis,harmony,heos,isy994,nanoleaf,octoprint,roku,songpal,synology_dsm,unifi,yeelight}': No such file or directory
Error: Process completed with exit code 2.

I think this is linked to #60294

@epenet epenet mentioned this pull request Nov 25, 2021
22 tasks
@frenck frenck self-assigned this Nov 25, 2021
@epenet epenet force-pushed the SsdpServiceInfo-a-f branch from 8f30387 to 1c9b280 Compare November 25, 2021 13:14
@epenet epenet force-pushed the SsdpServiceInfo-a-f branch from 1c9b280 to aaf8814 Compare November 25, 2021 13:14
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@frenck frenck merged commit 9eed18f into home-assistant:dev Nov 25, 2021
@epenet epenet deleted the SsdpServiceInfo-a-f branch November 25, 2021 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants