Conversation
probot-home-assistant
bot
added
new-feature
small-pr
frenck
commented
Nov 24, 2021
Comment on lines
+27
to
+28
| # test_full_suite: 'true' | ||
| test_full_suite: ${{ steps.info.outputs.test_full_suite }} |
Member
Author
There was a problem hiding this comment.
If something is fishy, this is the kill switch.
bdraco
reviewed
Nov 24, 2021
| if: needs.changes.outputs.test_full_suite == 'false' | ||
| run: | | ||
| . venv/bin/activate | ||
| pylint homeassistant/components/${{ needs.changes.outputs.integrations_glob }} |
bdraco
reviewed
Nov 24, 2021
Comment on lines
+71
to
+99
| if [[ "${{ steps.integrations.outputs.changes }}" != "[]" ]]; | ||
| then | ||
| # Create a file glob for the integrations | ||
| integrations_glob=$(echo '${{ steps.integrations.outputs.changes }}' | jq -cSr '. | join(",")') | ||
| [[ "${integrations_glob}" == *","* ]] && integrations_glob="{${integrations_glob}}" | ||
|
|
||
| # Create list of testable integrations | ||
| possible_integrations=$(echo '${{ steps.integrations.outputs.changes }}' | jq -cSr '.[]') | ||
| tests=$( | ||
| for integration in ${possible_integrations}; | ||
| do | ||
| if [[ -d "tests/components/${integration}" ]]; then | ||
| echo -n "\"${integration}\","; | ||
| fi; | ||
| done | ||
| ) | ||
|
|
||
| [[ ! -z "${tests}" ]] && tests="${tests::-1}" | ||
| tests="[${tests}]" | ||
| test_groups="${tests}" | ||
| # Test group count should be 1, we don't split partial tests | ||
| test_group_count=1 | ||
|
|
||
| # Create a file glob for the integrations tests | ||
| tests_glob=$(echo "${tests}" | jq -cSr '. | join(",")') | ||
| [[ "${tests_glob}" == *","* ]] && tests_glob="{${tests_glob}}" | ||
|
|
||
| test_full_suite="false" | ||
| fi |
Member
There was a problem hiding this comment.
In the future (not for this PR) would be nicer if this was generated by a python script so this would be easier to test. Reading this gives me a bit of a headache.
Member
Author
There was a problem hiding this comment.
For me its actually the opposite 😄
bdraco
approved these changes
Nov 24, 2021
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Second iteration on getting CI to run partially on PRs when possible, in order to speed up our CI.
Improvements in this PR:
changesjobs, that now determines all states used throughout the suite.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: