Skip to content

Cleanup DiscoveryFlowHandler #59576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epenet wants to merge 1 commit into from
Closed

Cleanup DiscoveryFlowHandler #59576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions homeassistant/helpers/config_entry_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,6 @@ async def async_step_discovery(

return await self.async_step_confirm()

async_step_zeroconf = async_step_discovery
Copy link
Copy Markdown
Member

@balloob balloob Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be here because async_step_discovery logic needs to be assigned to all these discovery steps. It's not assigning the same thing.

Copy link
Copy Markdown
Contributor Author

@epenet epenet Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balloob I have marked this as draft for now.
It was linked to PR 59503 - maybe you can take a look at this comment?
#59503 (comment)

async_step_ssdp = async_step_discovery
async_step_mqtt = async_step_discovery
async_step_homekit = async_step_discovery
async_step_dhcp = async_step_discovery

async def async_step_import(self, _: dict[str, Any] | None) -> FlowResult:
"""Handle a flow initialized by import."""
if self._async_current_entries():
Expand Down