Cleanup DiscoveryFlowHandler

[epenet]

Proposed change

Cleanup DiscoveryFlowHandler method redefinitions (async_step_zeroconf, async_step_ssdp, async_step_mqtt, async_step_homekit, async_step_dhcp) which seem redundant with the inherited definitions in ConfigFlow.

These redefinitions are causing mypy inheritance issues when working on #59503.
See the failed run https://github.com/home-assistant/core/runs/4167772127?check_suite_focus=true#step:7:12

Also see home-assistant/architecture#663

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[epenet]

The base class methods are here:

core/homeassistant/config_entries.py

Lines 1353 to 1357 in 363de37

	async def async_step_homekit(
	self, discovery_info: DiscoveryInfoType
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by Homekit discovery."""
	return await self.async_step_discovery(discovery_info)

core/homeassistant/config_entries.py

Lines 1359 to 1363 in 363de37

	async def async_step_mqtt(
	self, discovery_info: DiscoveryInfoType
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by MQTT discovery."""
	return await self.async_step_discovery(discovery_info)

core/homeassistant/config_entries.py

Lines 1365 to 1369 in 363de37

	async def async_step_ssdp(
	self, discovery_info: DiscoveryInfoType
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by SSDP discovery."""
	return await self.async_step_discovery(discovery_info)

core/homeassistant/config_entries.py

Lines 1371 to 1375 in 363de37

	async def async_step_zeroconf(
	self, discovery_info: DiscoveryInfoType
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by Zeroconf discovery."""
	return await self.async_step_discovery(discovery_info)

core/homeassistant/config_entries.py

Lines 1377 to 1381 in 363de37

	async def async_step_dhcp(
	self, discovery_info: DiscoveryInfoType
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by DHCP discovery."""
	return await self.async_step_discovery(discovery_info)

[Kane610]

Is this a breaking change for custom components?

[balloob]

These need to be here because async_step_discovery logic needs to be assigned to all these discovery steps. It's not assigning the same thing.

[epenet]

@balloob I have marked this as draft for now.
It was linked to PR 59503 - maybe you can take a look at this comment?
#59503 (comment)

[epenet]

I am closing this following the discussions on #59503 (comment)