Skip to content

Fix totalconnect config flow#59297

Closed
austinmroczek wants to merge 8 commits intohome-assistant:devfrom
austinmroczek:tcc_flow_fix
Closed

Fix totalconnect config flow#59297
austinmroczek wants to merge 8 commits intohome-assistant:devfrom
austinmroczek:tcc_flow_fix

Conversation

@austinmroczek
Copy link
Copy Markdown
Contributor

@austinmroczek austinmroczek commented Nov 7, 2021

Proposed change

This fixes the bug preventing new TotalConnect integrations being created from the configuration flow.

I forgot to account for an upstream change that used synchronous IO in a new spot, and it was hidden by the way I'm using Mock in tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title fix totalconnect config flow Fix totalconnect config flow Nov 7, 2021
@austinmroczek
Copy link
Copy Markdown
Contributor Author

Sorry I pulled from the wrong branch...

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2021
@austinmroczek austinmroczek deleted the tcc_flow_fix branch April 21, 2024 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants