Skip to content

Bump total_connect_client to 2021.11.2#58818

Merged
balloob merged 10 commits intohome-assistant:devfrom
austinmroczek:tcc_2021_10
Nov 7, 2021
Merged

Bump total_connect_client to 2021.11.2#58818
balloob merged 10 commits intohome-assistant:devfrom
austinmroczek:tcc_2021_10

Conversation

@austinmroczek
Copy link
Copy Markdown
Contributor

@austinmroczek austinmroczek commented Oct 31, 2021

Proposed change

Moves to total_connect_client version 2021.11.2, which corrects a bug preventing the arming or disarming of partitions. It also improves server retry logic and will result in significantly fewer log messages when there are connection problems.

https://github.com/craigjmidwinter/total-connect-client/releases/tag/2021.11.2

craigjmidwinter/total-connect-client@2021.8.3...2021.11.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

No changes to user interface or documentation. The biggest changes to total_connect_client were ResultCode consts moving to an enum and removal of is_valid_credentials in favor of is_logged_in.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [n/a] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

58813 and 56647

@briglx
Copy link
Copy Markdown
Contributor

briglx commented Oct 31, 2021

Looks good to me

@MartinHjelmare MartinHjelmare changed the title Move totalconnect to total_connect_client 2021.10 Bump total_connect_client to 2021.10 Oct 31, 2021
@austinmroczek austinmroczek changed the title Bump total_connect_client to 2021.10 Bump total_connect_client to 2021.11.1 Nov 5, 2021
@austinmroczek
Copy link
Copy Markdown
Contributor Author

This PR was originally submitted (and reviewed, thank you) prior to #59023 being identified. I know we would normally not want to mix PRs. However bumping to total_connect_client to 2021.11.1 fixes that bug, and all of the changes in this PR were necessary anyways.

@austinmroczek austinmroczek changed the title Bump total_connect_client to 2021.11.1 Bump total_connect_client to 2021.11.2 Nov 6, 2021
@austinmroczek
Copy link
Copy Markdown
Contributor Author

austinmroczek commented Nov 6, 2021

Now it moves to total_connect_client 2021.11.2, which fixes the ResultCode item discussed above.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.11.2 milestone Nov 7, 2021
@austinmroczek austinmroczek mentioned this pull request Nov 7, 2021
21 tasks
@balloob balloob merged commit 72aaeda into home-assistant:dev Nov 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
@austinmroczek austinmroczek deleted the tcc_2021_10 branch April 21, 2024 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants