Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluez to the devcontainer #55469

Merged
merged 7 commits into from
Sep 4, 2021

Conversation

chemelli74
Copy link
Contributor

Proposed change

Add bluez installation task to dev container

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix small-pr PRs with less than 30 lines. labels Aug 30, 2021
@chemelli74 chemelli74 requested a review from ludeeus August 30, 2021 19:16
@chemelli74 chemelli74 mentioned this pull request Aug 30, 2021
21 tasks
Dockerfile.dev Outdated Show resolved Hide resolved
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an issue with adding this, but I'll request a second opinion for it.

@ludeeus ludeeus added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Aug 30, 2021
@elupus
Copy link
Contributor

elupus commented Aug 30, 2021

Why hasn't this been an issue before. There was a ble device tracker before that used bluez.

Seems a bit strange to point out fjäråskupan specifically here. Seems likely to be outdated once other tests are added?

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

When VSCode runs the test discovery for the fjaraskupan integration, https://github.com/hbldh/bleak/blob/develop/bleak/__init__.py#L36 is loaded/executed.

Dockerfile.dev Outdated Show resolved Hide resolved
@ludeeus ludeeus changed the title Fix fjaraskupan dependency for tests Add bluez to the devcontainer Aug 31, 2021
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it. I would probably have just dropped the comment or mentioning "bleak' python package as initial source. But it's no difference from need of libs format, and those don't mention why it's added.

@chemelli74
Copy link
Contributor Author

I don't have an issue with adding this, but I'll request a second opinion for it.

Should be all set now, right ?

Simone

@chemelli74 chemelli74 removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Sep 2, 2021
@chemelli74 chemelli74 merged commit b7e8348 into home-assistant:dev Sep 4, 2021
@chemelli74 chemelli74 deleted the chemelli74-requirement branch September 4, 2021 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants