-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bluez to the devcontainer #55469
Add bluez to the devcontainer #55469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an issue with adding this, but I'll request a second opinion for it.
Why hasn't this been an issue before. There was a ble device tracker before that used bluez. Seems a bit strange to point out fjäråskupan specifically here. Seems likely to be outdated once other tests are added? |
When VSCode runs the test discovery for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it. I would probably have just dropped the comment or mentioning "bleak' python package as initial source. But it's no difference from need of libs format, and those don't mention why it's added.
Should be all set now, right ? Simone |
Proposed change
Add
bluez
installation task to dev containerType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: