Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode task code coverage #53783

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jul 30, 2021

Proposed change

This will add a new VSCode task to start code coverage report for a specific integration:

image

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Jul 30, 2021
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A nice addition !! Thanks @mib1185

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component -> integration

.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
Co-authored-by: Joakim Sørensen <[email protected]>
@ludeeus ludeeus merged commit 29e604b into home-assistant:dev Aug 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
@chemelli74
Copy link
Contributor

Test discovery task fails here, reverting this change make it works again.

Simone

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

There is no "Test discovery" task

@chemelli74
Copy link
Contributor

There is no "Test discovery" task

Is part of VScode:

image

Here's the reference PR in witch pytest was configured to make it working out of the box: #53203

Simone

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

That is still working on current dev.

Screenshot from 2021-08-30 16-30-22

@janiversen
Copy link
Member

I can confirm that it works!

could the problem be a failing test, in that case “test discovery” fails.

@chemelli74
Copy link
Contributor

That is still working on current dev.

Did you rebuild the dev container ?
Here it still gives error:

image

Will investigate further asap.

Simone

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

On a fresh devcontainer you need to install bluez as bluetoothctl is used when scanning the tests for fjaraskupan

@chemelli74
Copy link
Contributor

On a fresh devcontainer you need to install bluez as bluetoothctl is used when scanning the tests for fjaraskupan

Oh really ? Since when ?
And why is not in the requirements ?

Simone

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

Yes, I don't know.
I don't know.

@chemelli74
Copy link
Contributor

On a fresh devcontainer you need to install bluez as bluetoothctl is used when scanning the tests for fjaraskupan

Running apt-get install bluez fixed it. Thx for the hint.
May we consider add it to Dockerfile.dev as additional run task ?

could the problem be a failing test, in that case “test discovery” fails.

Nope, I have a failing test but discovery worked fine; is just a matter of dependecies.

Simone

@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2021

I don't see an issue with adding it, make a PR to have that discussion there instead of here.

@chemelli74
Copy link
Contributor

I don't see an issue with adding it, make a PR to have that discussion there instead of here.

Done: #55469

Simone

@mib1185 mib1185 deleted the vscode/add-code-covergae-task branch November 1, 2021 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants