Skip to content

Minor cleanup of SensorEntity#54624

Merged
frenck merged 3 commits intohome-assistant:devfrom
emontnemery:sensor_temperature_conversion_tweak
Aug 19, 2021
Merged

Minor cleanup of SensorEntity#54624
frenck merged 3 commits intohome-assistant:devfrom
emontnemery:sensor_temperature_conversion_tweak

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Aug 14, 2021

Proposed change

Minor cleanup of SensorEntity:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery
Copy link
Copy Markdown
Contributor Author

emontnemery commented Aug 14, 2021

The failing tests will be fixed by #54623, this PR needs to be rebased once that's merged
The PR is rebased and the tests should now pass

@emontnemery emontnemery changed the title Remove backwards compatibility code from SensorEntity Minor cleanup of SensorEntity Aug 15, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 16, 2021
@@ -221,10 +221,6 @@ def unit_of_measurement(self) -> str | None:
@property
def state(self) -> Any:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mark the state method final and re-type _attr_state: None = None.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 16, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

Does this have any breaking impact on custom integrations?

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Aug 19, 2021

Does this have any breaking impact on custom integrations?

Potentially, I scanned 576 custom integrations, 3 was using _attr_state (1 did not inherit SensorEntity so unaffected), the other 2 got a PR to move them to _attr_native_value

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frenck frenck merged commit 4903c1f into home-assistant:dev Aug 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants