Skip to content

Move temperature conversions to sensor base class - new integrations#54623

Merged
emontnemery merged 5 commits intohome-assistant:devfrom
emontnemery:sensor_temperature_conversion_9
Aug 15, 2021
Merged

Move temperature conversions to sensor base class - new integrations#54623
emontnemery merged 5 commits intohome-assistant:devfrom
emontnemery:sensor_temperature_conversion_9

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Move temperature conversions to sensor base class

This migrates a few additional integrations which were added or modified after #48261 was last updated

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from azogue as a code owner August 14, 2021 10:31
@emontnemery emontnemery mentioned this pull request Aug 14, 2021
21 tasks
Copy link
Copy Markdown
Member

@azogue azogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pvpc_hourly_pricing 👍

@emontnemery emontnemery changed the title Move temperature conversions to sensor base class Move temperature conversions to sensor base class - new integrations Aug 14, 2021
@emontnemery emontnemery dismissed ludeeus’s stale review August 15, 2021 06:51

The requested changes have been fixed

@emontnemery emontnemery merged commit 87e7a8f into home-assistant:dev Aug 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants