Skip to content

Update aiohomekit to subscribe more like iOS#50997

Merged
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:hc_bump_263
May 23, 2021
Merged

Update aiohomekit to subscribe more like iOS#50997
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:hc_bump_263

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 23, 2021 •
edited
Loading

Proposed change

  • Subscribes to one aid/iid at a time to mimic iOS
  • Closes the connection to invalidate the subscriptions instead of unsubs to mimic iOS

Changelog: Jc2k/aiohomekit@0.2.62...0.2.64

Fixes #37996

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Update aiohomekit to subscribe more like iOS
cf0b23c 
- Subscribes to one aid/iid at a time to mimic iOS
- Closes the connection to invalidate the subscriptions instead of unsubs to mimic iOS

Fixes home-assistant#37996
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented May 23, 2021

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with an integration (homekit_controller) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review May 23, 2021 14:05
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2021

Tested, verified close working as expected 👍

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2021

The test fixture needs to be made async

https://github.com/Jc2k/aiohomekit/blob/main/aiohomekit/testing.py#L198

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2021 •
edited
Loading

PR to fix the test fixture Jc2k/aiohomekit#32

@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label May 23, 2021
@bdraco bdraco marked this pull request as draft May 23, 2021 14:37
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented May 23, 2021

0.2.64 released with test fixture fix.

@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label May 23, 2021
@bdraco bdraco marked this pull request as ready for review May 23, 2021 17:41
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 23, 2021

Retested. All good

Jc2k
Jc2k approved these changes May 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant - LGTM

@bdraco bdraco merged commit 3cef96e into home-assistant:dev May 23, 2021
@bdraco bdraco deleted the hc_bump_263 branch May 23, 2021 18:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Jc2k Jc2k Jc2k approved these changes

Assignees

@Jc2k Jc2k

Labels

by-code-owner cla-signed integration: homekit_controller small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

homekit_controller: Events stop working when there are over 26 entities

3 participants

@bdraco @Jc2k @homeassistant