Make close an async def for FakePairing testing#32
Merged
Conversation
21 tasks
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 85.37% 85.28% -0.10%
==========================================
Files 45 45
Lines 3303 3303
==========================================
- Hits 2820 2817 -3
- Misses 483 486 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jc2k
approved these changes
May 23, 2021
Collaborator
Author
|
I think the windows test here is flakey. I'll amend and repush to make sure its just a transient failure |
Owner
|
Yes there is a flakey test. It flakes most on Windows, but I have seen it flake on them all 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.