Skip to content

Fix Volvo On Call lock state #50832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielhiversen merged 5 commits into from
May 22, 2021
Merged

Fix Volvo On Call lock state #50832

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
740a960
Fix Volvo On Call: Locked shows as Unlocked #43260 and #49224
victorclaessen May 18, 2021
bd2cabc
Update binary_sensor.py
victorclaessen May 18, 2021
7de1ded
Merge branch 'home-assistant:dev' into volvooncall_lock_fix
victorclaessen May 18, 2021
dc09943
Update homeassistant/components/volvooncall/binary_sensor.py
victorclaessen May 19, 2021
0a0f1a8
Update binary_sensor.py
victorclaessen May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/volvooncall/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ class VolvoSensor(VolvoEntity, BinarySensorEntity):

@property
def is_on(self):
"""Return True if the binary sensor is on."""
return self.instrument.is_on
"""Return True if the binary sensor is on, but invert for the 'Door lock'."""
if self.instrument.attr == "is_locked":
return not self.instrument.is_on
else:
return self.instrument.is_on

@property
def device_class(self):
Expand Down