Skip to content

Fix Volvo On Call lock state#50832

Merged
Danielhiversen merged 5 commits intohome-assistant:devfrom
victorclaessen:volvooncall_lock_fix
May 22, 2021
Merged

Fix Volvo On Call lock state#50832
Danielhiversen merged 5 commits intohome-assistant:devfrom
victorclaessen:volvooncall_lock_fix

Conversation

@victorclaessen
Copy link
Copy Markdown
Contributor

@victorclaessen victorclaessen commented May 18, 2021

Proposed change

In the volvooncall component, the value of the 'Door lock' binary sensor is inverted, which has been reported in #43260 and #49224. This pull request fixes this by inverting the status only for that specific component (selected by the name of the component).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

  • I do not think I am qualified yet to review two other open pull requests in this repository.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @victorclaessen,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Fix Volvo On Call: Locked shows as Unlocked #43260 and #49224 Fix Volvo On Call lock state May 18, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Amend code to pass pylint test
@Danielhiversen Danielhiversen merged commit a03ee1e into home-assistant:dev May 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inverted door lock status Volvo On Call: Locked shows as Unlocked

4 participants