Add strict type annotations to acer_projector#50657
Add strict type annotations to acer_projector#50657frenck merged 5 commits intohome-assistant:devfrom
Conversation
KapJI
left a comment
There was a problem hiding this comment.
Please move constants to const.py and make them Final.
Is it really needed for a single component integration? |
|
I think nicer structure is good. If someone will add another component, it will be easier to extend and maintain good structure. |
|
Btw, this integration doesn't have a code owner. Should we add someone? It was created very long time ago: #1913 |
My intention is to add annotations to integrations, which has no codeowner and therefore might never be touched - but honestly would not like to become the codeowner of them all 🙈 |
|
I can become the code owner. I wouldn't mind. I haven't done too much for HA in the last months, but I can definitely step it up and take more responsibility for my Components. However I don't really know what this means. I guess it means I have to bring the code in line with all the new developments going on. Is there some documentation available on when and what i need to do something? |
|
Basically it means you'll be added as a reviewer to PRs which touch these components. Shouldn't be much traffic. There's no obligation to update them according to current standards. Also you'll be pinged on issues related to these components. @mib1185 can you update the manifest please? 🙂 |
|
@deisi are you ok with that? 🙂 |
|
@mib1185 Existing codeowner doesn't have to agree. If you want to help out as a codeowner, then, please add yourself. Any help anywhere is always welcomed 👍 |
|
@mib1185 Right, but that isn't related to this PR. |
|
ah ... no I get what you mean 🙂 👍 |
I'm fine with that :) |
Proposed change
Add strict type annotations.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: