Added a switch to control beamers from acer#1913
Conversation
There was a problem hiding this comment.
PySerial 3 introduced a new API. Are you sure that your component works if you are using PySerial 2 or do you need to restrict the version ?
There was a problem hiding this comment.
I have only tested version3. I guess ist best if I just restrict the version.
|
Changed beamer to projector and limited the pyserial version to be >= 3.0. |
|
Okay, Currently it doesnt work with these REQUIREMENTS. I get But I don't get why. In an interactive session it works. |
|
So the problem is, with: it works. I use pyserial from arch linux repo witch is: |
|
Well that's Home Assistant installing the version from pypi. Since PySerial changed their API, you need to filter out the versions that do not support the API that you are using. |
|
Ah Okay, I will test what version works ASAP. On 02.05.2016 08:04, Paulus Schoutsen wrote:
|
|
The stacktrace your seeing is similar to rgis reported bug in pyserial: A fix has been merged in master but there's no new release yet. This is the same problem as reported in: |
|
I see. I will try with pyserial 2.7 then. Lets see what version works. On 02.05.2016 10:50, Martin Hjelmare wrote:
|
Description:
Allows to control a RS232 connected projectors from acer.
Almost all Projectors from Acer have a serial RS232 interface and can be controlled via it. This switch component allows to determine the state of the projector and to turn it on or off. It further reads the Lamp Hours, Input Source and if possible the state of the ECO Mode as attributes.
Example entry for
configuration.yaml(if applicable):I would totally understand if you say that this PR can not be merged because a projector is not a switch.
Up to now I have not introduced a new device class to HA and using a switch was the easiest. What is the general opinion on this?
Checklist:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass