Merged
Conversation
10 tasks
frenck
approved these changes
May 7, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
Reverted the typing change, as it triggered Pylint (and doesn't attribute to the fix at this point), so decided to remove it.
Tested:
- Current entry still works (after upgrade, selects HTTPS)
- Setting up new integration works (selects HTTPS)
- Manual entry with an invalid address (tries, HTTPS, falls back to HTTP and eventually fails as expected).
MartinHjelmare
approved these changes
May 7, 2021
frenck
added a commit
that referenced
this pull request
May 7, 2021
Co-authored-by: Franck Nijhof <git@frenck.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Bump aiohue to 2.3.0
home-assistant-libs/aiohue@2.1.0...2.3.0
https://github.com/home-assistant-libs/aiohue/releases/tag/2.2.0
https://github.com/home-assistant-libs/aiohue/releases/tag/2.3.0
Fixes #48286
Fixes #50110
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: