Skip to content

Bump aiohue to 2.3.0#50217

Merged
frenck merged 2 commits intodevfrom
upgrade-hue-2.3.0
May 7, 2021
Merged

Bump aiohue to 2.3.0#50217
frenck merged 2 commits intodevfrom
upgrade-hue-2.3.0

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 7, 2021

Breaking change

Proposed change

Bump aiohue to 2.3.0

home-assistant-libs/aiohue@2.1.0...2.3.0

https://github.com/home-assistant-libs/aiohue/releases/tag/2.2.0
https://github.com/home-assistant-libs/aiohue/releases/tag/2.3.0

Fixes #48286
Fixes #50110

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @frenck, mind taking a look at this pull request as its been labeled with an integration (hue) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the typing change, as it triggered Pylint (and doesn't attribute to the fix at this point), so decided to remove it.

Tested:

  • Current entry still works (after upgrade, selects HTTPS)
  • Setting up new integration works (selects HTTPS)
  • Manual entry with an invalid address (tries, HTTPS, falls back to HTTP and eventually fails as expected).

@frenck frenck merged commit 17fc962 into dev May 7, 2021
@frenck frenck deleted the upgrade-hue-2.3.0 branch May 7, 2021 12:24
frenck added a commit that referenced this pull request May 7, 2021
Co-authored-by: Franck Nijhof <git@frenck.dev>
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot connect to Phillips hue bridge.

4 participants