Bump aiohue to current version 2.2.0#48286
Bump aiohue to current version 2.2.0#48286bugfinder wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
Hi @bugfinder, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
frenck
left a comment
There was a problem hiding this comment.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Additionally, please restore the PR template and fill it out.
Thanks already! 👍
|
I hope I did all the required changes in the description |
There was a problem hiding this comment.
I think this needs adjustments on the Home Assistant end (please correct me if I'm wrong).
Since sensors & scenes can now be None on the aiohue.bridge. That is something Home Assistant doesn't always expect. For example, the bridge on the Home Assistant end will try to iterate over the scene when hue_activate_scene is called. None isn't iterable.
core/homeassistant/components/hue/bridge.py
Line 205 in d417dcb
I suspect similar behavior in the sensor manager to be honest.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
changed: https://github.com/home-assistant-libs/aiohue/releases/tag/2.2.0
compare: home-assistant-libs/aiohue@2.1.0...2.2.0
Breaking change
Proposed change
update the dependency to the current version
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: