Skip to content

Bump aiohue to current version 2.2.0#48286

Closed
bugfinder wants to merge 1 commit intohome-assistant:devfrom
bugfinder:bump_aiohue_dev
Closed

Bump aiohue to current version 2.2.0#48286
bugfinder wants to merge 1 commit intohome-assistant:devfrom
bugfinder:bump_aiohue_dev

Conversation

@bugfinder
Copy link
Copy Markdown

@bugfinder bugfinder commented Mar 24, 2021

changed: https://github.com/home-assistant-libs/aiohue/releases/tag/2.2.0
compare: home-assistant-libs/aiohue@2.1.0...2.2.0

Breaking change

Proposed change

update the dependency to the current version

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @bugfinder,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added integration: hue small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels Mar 24, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Additionally, please restore the PR template and fill it out.

Thanks already! 👍

@bugfinder
Copy link
Copy Markdown
Author

I hope I did all the required changes in the description

@bugfinder bugfinder requested a review from frenck April 6, 2021 22:13
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs adjustments on the Home Assistant end (please correct me if I'm wrong).

Since sensors & scenes can now be None on the aiohue.bridge. That is something Home Assistant doesn't always expect. For example, the bridge on the Home Assistant end will try to iterate over the scene when hue_activate_scene is called. None isn't iterable.

async def hue_activate_scene(self, call, updated=False, hide_warnings=False):

I suspect similar behavior in the sensor manager to be honest.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 6, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 6, 2021
@balloob balloob mentioned this pull request May 7, 2021
21 tasks
@frenck frenck closed this in #50217 May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency-bump Pull requests that update a dependency file integration: hue small-pr PRs with less than 30 lines. stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants