Skip to content

Add value map for Climacell V3 pollen sensors#50200

Merged
balloob merged 1 commit intohome-assistant:devfrom
raman325:climacell_pollen
May 7, 2021
Merged

Add value map for Climacell V3 pollen sensors#50200
balloob merged 1 commit intohome-assistant:devfrom
raman325:climacell_pollen

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented May 6, 2021

Proposed change

The ClimaCell V3 pollen sensors use an enum which I missed (the V4 sensors also use an enum but I caught that). I had to bump the dependency to add support for the enum but the changes were minimal: raman325/pyclimacell@v0.18.0...v0.18.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 9f1b1c6 into home-assistant:dev May 7, 2021
@raman325 raman325 deleted the climacell_pollen branch May 7, 2021 05:57
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants