Skip to content

python3Packages.pyclimacell: 0.18.0 -> 0.18.2#122036

Merged
jonringer merged 2 commits intoNixOS:masterfrom
fabaff:bump-pyclimacell
May 7, 2021
Merged

python3Packages.pyclimacell: 0.18.0 -> 0.18.2#122036
jonringer merged 2 commits intoNixOS:masterfrom
fabaff:bump-pyclimacell

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented May 7, 2021

Motivation for this change

Update to latest upstream release 0.18.2

Change log: no change log available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners May 7, 2021 14:56
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 7, 2021
@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented May 7, 2021

Result of nixpkgs-review pr 122036 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.pyclimacell
  • python39Packages.pyclimacell

@ofborg ofborg bot requested review from Mic92, globin and mweinelt May 7, 2021 15:05
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2021
jonringer
jonringer approved these changes May 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122036 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.pyclimacell
  • python39Packages.pyclimacell

@fabaff fabaff deleted the bump-pyclimacell branch May 8, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@Mic92 Mic92 Awaiting requested review from Mic92

@mweinelt mweinelt Awaiting requested review from mweinelt

@globin globin Awaiting requested review from globin

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

Home Assistant
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabaff @jonringer