Skip to content

Denonavr bugfixes#49984

Merged
bdraco merged 2 commits intohome-assistant:devfrom
ol-iver:denonavr-update
May 7, 2021
Merged

Denonavr bugfixes#49984
bdraco merged 2 commits intohome-assistant:devfrom
ol-iver:denonavr-update

Conversation

@ol-iver
Copy link
Copy Markdown
Contributor

@ol-iver ol-iver commented May 2, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix dependency Pull requests marked as a dependency upgrade integration: denonavr small-pr PRs with less than 30 lines. labels May 2, 2021
@probot-home-assistant
Copy link
Copy Markdown

Hey there @starkillerOG, mind taking a look at this pull request as its been labeled with an integration (denonavr) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 7, 2021

Tested and working 👍

@bdraco bdraco merged commit 0cf07ee into home-assistant:dev May 7, 2021
frenck pushed a commit that referenced this pull request May 7, 2021
@frenck frenck mentioned this pull request May 7, 2021
@ol-iver ol-iver deleted the denonavr-update branch May 8, 2021 09:24
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: denonavr small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

denonavr component unable to change source, reporting different source name

4 participants