Skip to content

python3Packages.denonavr: 0.9.10 -> 0.10.6#121153

Merged
mweinelt merged 3 commits intoNixOS:masterfrom
fabaff:bump-denonavr
May 7, 2021
Merged

python3Packages.denonavr: 0.9.10 -> 0.10.6#121153
mweinelt merged 3 commits intoNixOS:masterfrom
fabaff:bump-denonavr

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Apr 29, 2021 •
edited
Loading

Motivation for this change

Update to latest upstream release 0.10.5

Change log: https://github.com/scarface-4711/denonavr/releases/tag/0.10.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners April 29, 2021 12:45
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 29, 2021
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 29, 2021

Check if you can enable the tests. The package bump was home-assistant/core#47920 and came with a bunch of code changes moving the component to async.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 29, 2021
@ofborg ofborg bot requested a review from colemickens April 29, 2021 12:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 29, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Apr 29, 2021 •
edited
Loading

Result of nixpkgs-review pr 121153 at ab012688 run on x86_64-linux 1

4 packages built successfully:
  • python38Packages.async-lru
  • python38Packages.denonavr
  • python39Packages.async-lru
  • python39Packages.denonavr

Result of nixpkgs-review pr 121153 at ab012688 run on aarch64-linux 1

4 packages built successfully:
  • python38Packages.async-lru
  • python38Packages.denonavr
  • python39Packages.async-lru
  • python39Packages.denonavr

@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented May 4, 2021

Looks like we could enable the tests after Home Assistant 2021.5.

@mweinelt mweinelt self-assigned this May 4, 2021
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented May 6, 2021 •
edited
Loading

Let's drop async-lru and updated to https://github.com/scarface-4711/denonavr/releases/tag/0.10.6, and enable those tests.

@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented May 7, 2021

Result of nixpkgs-review pr 121153 run on x86_64-linux 1

5 packages built:
  • home-assistant
  • python38Packages.asyncstdlib
  • python38Packages.denonavr
  • python39Packages.asyncstdlib
  • python39Packages.denonavr

@fabaff fabaff changed the title python3Packages.denonavr: 0.9.10 -> 0.10.5 python3Packages.denonavr: 0.9.10 -> 0.10.6 May 7, 2021
@ofborg ofborg bot requested review from Mic92, globin and mweinelt May 7, 2021 17:32
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented May 7, 2021

Test failures are unrelated.

@mweinelt mweinelt merged commit 144dc28 into NixOS:master May 7, 2021
@fabaff fabaff deleted the bump-denonavr branch May 7, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@colemickens colemickens Awaiting requested review from colemickens

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

Assignees

@mweinelt mweinelt

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Home Assistant
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @mweinelt @r-rmcgibbo