Skip to content

Revert "Support overriding token in notifify.event service (#47133)"#48949

Closed
balloob wants to merge 1 commit intodevfrom
revert-custom-token
Closed

Revert "Support overriding token in notifify.event service (#47133)"#48949
balloob wants to merge 1 commit intodevfrom
revert-custom-token

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 9, 2021

This reverts commit 056f7d4.

Breaking change

Proposed change

PR #47133 was not tested and did not work.

Fixes #48739
Closes #48928

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2021.4.2 milestone Apr 9, 2021
@probot-home-assistant
Copy link
Copy Markdown

Hey there @matrozov, @papajojo, mind taking a look at this pull request as its been labeled with an integration (notify_events) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob removed this from the 2021.4.2 milestone Apr 9, 2021
@balloob balloob closed this Apr 9, 2021
@balloob balloob deleted the revert-custom-token branch April 9, 2021 17:11
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'trim' in notify.py (notify_events)

3 participants