Support overriding token in notifify.event service#47133
Merged
emontnemery merged 2 commits intohome-assistant:devfrom Mar 25, 2021
papajojo:dev
Merged
Support overriding token in notifify.event service#47133emontnemery merged 2 commits intohome-assistant:devfrom papajojo:dev
emontnemery merged 2 commits intohome-assistant:devfrom
papajojo:dev
Conversation
8 tasks
emontnemery
reviewed
Mar 23, 2021
Contributor
|
On a general note, the notify_events integration should have some tests added (not blocking this PR though). |
Co-authored-by: Erik Montnemery <erik@montnemery.com>
emontnemery
approved these changes
Mar 25, 2021
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Looks good, thanks @papajojo 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Support overriding token in notifify.event service
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: