Skip to content

Clean and optimize systemmonitor#48699

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bdraco:systemmonitor_touch_ups
Apr 5, 2021
Merged

Clean and optimize systemmonitor#48699
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bdraco:systemmonitor_touch_ups

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 5, 2021

Breaking change

The last_boot time is now returned in UTC

Proposed change

  • Remove unneeded excinfo to _LOGGER.exception
  • Use f-strings
  • Switch last_boot to utc
  • Cache psutil/os calls used by multiple attributes in the same update cycle

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- Remove unneeded excinfo to _LOGGER.exception
- Use f-strings
- Switch last_boot to utc
- Cache psutil/os calls used by multiple attributes in the same update cycle
@MartinHjelmare MartinHjelmare changed the title systemmonitor cleanups and optimizations Clean and optimize systemmonitor Apr 5, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit c28d4e8 into home-assistant:dev Apr 5, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants