Skip to content

Update all systemmonitor sensors in one executor call#48689

Merged
bdraco merged 5 commits into
home-assistant:devfrom
bdraco:system_monitor_reduce_executor
Apr 5, 2021
Merged

Update all systemmonitor sensors in one executor call#48689
bdraco merged 5 commits into
home-assistant:devfrom
bdraco:system_monitor_reduce_executor

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 5, 2021

Proposed change

  • All sensors are now updated in one jump to the executor (reduces the number of created SyncWorkers at startup if the executor isn't already starved)
  • Typing now in more places
  • throughput_network_out was missing a list element

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- All sensors are now update in one jump to the executor
- Typing now in more places
- throughput_network_out was missing a list element
@bdraco bdraco changed the title Update all systemmonitor systems in one executor call Update all systemmonitor sensors in one executor call Apr 5, 2021
Comment thread homeassistant/components/systemmonitor/sensor.py
Comment thread homeassistant/components/systemmonitor/sensor.py
Comment thread homeassistant/components/systemmonitor/sensor.py Outdated
Comment thread homeassistant/components/systemmonitor/sensor.py
Comment thread homeassistant/components/systemmonitor/sensor.py Outdated
bdraco and others added 2 commits April 4, 2021 17:42
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 5, 2021

Thanks. Retested 👍

@bdraco bdraco merged commit 0544d94 into home-assistant:dev Apr 5, 2021
@bdraco bdraco deleted the system_monitor_reduce_executor branch April 5, 2021 08:11
Comment thread homeassistant/components/systemmonitor/sensor.py
Comment thread homeassistant/components/systemmonitor/sensor.py
Comment thread homeassistant/components/systemmonitor/sensor.py
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants