Skip to content

Remove modbus duplicate strings#48654

Merged
MartinHjelmare merged 6 commits into
home-assistant:devfrom
janiversen:use_ha_strings
Apr 4, 2021
Merged

Remove modbus duplicate strings#48654
MartinHjelmare merged 6 commits into
home-assistant:devfrom
janiversen:use_ha_strings

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Clenaup const.py by removing strings defined in the HA core system.

Sort/group remaining strings in const.py.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Reusing HA consts reduces the need for translation.

Sort/group constants in const.
Comment thread homeassistant/components/modbus/__init__.py Outdated
@MartinHjelmare MartinHjelmare changed the title remove duplicate strings (typically defined in homeassistant/const.py) Remove modbus duplicate strings Apr 3, 2021
Comment thread homeassistant/components/modbus/__init__.py Outdated
Comment thread homeassistant/components/modbus/__init__.py Outdated
Comment thread homeassistant/components/modbus/climate.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread homeassistant/components/modbus/climate.py
Avoid possible division problem in set_temperature.
@janiversen
Copy link
Copy Markdown
Member Author

While solving the lint problem, I back ported the check for kwargs to avoid problems.

@MartinHjelmare MartinHjelmare merged commit 2511e1f into home-assistant:dev Apr 4, 2021
@janiversen janiversen deleted the use_ha_strings branch April 4, 2021 13:55
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants