Add support for capturing renewals to dhcp discovery#48242
Conversation
|
@scyto if you checkout this PR and run it, does it now find your roomba? |
This comment has been minimized.
This comment has been minimized.
Sounds good to me. This changed solved the renewal case for one of my networks so it looks like it will improve the status quo even if it doesn't solve the case you are seeing. Thanks for testing |
|
Improvement is always good! I hate it at work when we say 'well that only solves an edge case so lets not do it' or worse 'we can't solved all edge cases so lets not do it' :-) I know how to generate a broadcast packet on demand from both i7 and 980 models. I do need one tip. if you have the time. This time rather than do anything with vscode on windows I cloned my fork to my debian box, checked out my branch. Setup the python virtual env. Ran hassfest, tweaked files. Now when i deactivate the python virtual env and then if I check in the branch am i going to mess up all the files? I never did the upstream command. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
faa5414 to
2b25eb5
Compare
|
Nothing wrong here. Marked a few comments about tool usage off-topic since it would be a distraction to reviewers. |
|
Thank you 🙏🏻 |
Proposed change
Add support for capturing renewals to dhcp discovery
This should speed things up quite a bit for more users as we don't have to wait for a power off/power on event.
Explains why #47696 could never see the roomba
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: