Add Leviosa Motor Shades Zone hub integration #48048
Closed
altersis wants to merge 8 commits into
Closed
Conversation
probot-home-assistant
Bot
added
has-tests
new-integration
integration: leviosa_shades
labels
11 tasks
8 tasks
RobBie1221
reviewed
May 8, 2021
Contributor
RobBie1221
left a comment
RobBie1221
left a comment
There was a problem hiding this comment.
Just some cleanup comments
Comment on lines
+21
to
+24
| for component in PLATFORMS: | ||
| hass.async_create_task( | ||
| hass.config_entries.async_forward_entry_setup(entry, component) | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| for component in PLATFORMS: | |
| hass.async_create_task( | |
| hass.config_entries.async_forward_entry_setup(entry, component) | |
| ) | |
| hass.config_entries.async_setup_platforms(entry, PLATFORMS) |
Comment on lines
+31
to
+38
| unload_ok = all( | ||
| await asyncio.gather( | ||
| *[ | ||
| hass.config_entries.async_forward_entry_unload(entry, component) | ||
| for component in PLATFORMS | ||
| ] | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| unload_ok = all( | |
| await asyncio.gather( | |
| *[ | |
| hass.config_entries.async_forward_entry_unload(entry, component) | |
| for component in PLATFORMS | |
| ] | |
| ) | |
| ) | |
| unload_ok = await hass.config_entries.async_unload_platforms(entry, PLATFORMS) |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Have already submitted the PR for the Logos, will be submitting the documentation PR shortly after this one.
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: