Skip to content

Add images for Leviosa Motorized Shades#2337

Closed
altersis wants to merge 7 commits into
home-assistant:masterfrom
Leviosa-Shades:master
Closed

Add images for Leviosa Motorized Shades#2337
altersis wants to merge 7 commits into
home-assistant:masterfrom
Leviosa-Shades:master

Conversation

@altersis
Copy link
Copy Markdown

@altersis altersis commented Mar 17, 2021

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds brand images for a core integration I cannot find.
Is there a parent PR that adds this integration to our core codebase?

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 17, 2021
@altersis
Copy link
Copy Markdown
Author

altersis commented Mar 17, 2021

Hi, yes, there will be in a couple of hours. I'm close to creating a PR for the Leviosa Shades integration code and one for the Documentation. Should I create those PRs first, then update this one? I thought the images had to be done first, as the other two need the images to be in place to display properly, right?
Edit: The PR for the integration code is #48048

@altersis altersis requested a review from frenck March 17, 2021 20:53
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Mar 18, 2021
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Mar 18, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 18, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 24, 2021

Closing PR as the parent PR has been closed.

@frenck frenck closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaits-parent Awaits the merge of an parent PR cla-signed has-parent This PR has a parent PR in a other repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants