Add images for Leviosa Motorized Shades#2337
Closed
altersis wants to merge 7 commits into
Closed
Conversation
not needed
Add Leviosa Motorized shades to brands in Home Assistant
frenck
requested changes
Mar 17, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
This PR adds brand images for a core integration I cannot find.
Is there a parent PR that adds this integration to our core codebase?
Author
|
Hi, yes, there will be in a couple of hours. I'm close to creating a PR for the Leviosa Shades integration code and one for the Documentation. Should I create those PRs first, then update this one? I thought the images had to be done first, as the other two need the images to be in place to display properly, right? |
frenck
approved these changes
Mar 18, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
8 tasks
Member
|
Closing PR as the parent PR has been closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png)icon@2x.png)logo.png)logo@2x.png)