Fix Xiaomi Miio flow unique_id for non discovery flows

[starkillerOG]

Breaking change

Proposed change

Attempt 2 to fix Miio import

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes Discovered Xiaomi Miio device not recognizable #47006
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
_{^{(message by ReviewEnforcer)}}

[probot-home-assistant]

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[frenck]

This should not be needed, as user setups always override discovery.

Additionally, the issue that was tried to fix here, turned out not to be an issue.

@starkillerOG I suggest on closing this PR.

[starkillerOG]

As frenck mentioned, this turned out not to be an issue but some unrelated network problem.
Therefore closing this PR.

[MartinHjelmare]

Thanks!

[starkillerOG]

@frenck @MartinHjelmare note that this function is used for both the import, discovery and user flow (they all use this same code).
I am not sure what the effect of raise_on_progress=False will be.

Schould we distinguis between import, discovery and user flows, or can they all have raise_on_progress=False

[MartinHjelmare]

Import and user should not raise on progress. Discovery should raise on progress (the default).

[starkillerOG]

@MartinHjelmare on a unrelated note,
The final two PRs to finish the Miio config flow are ready:
#47161
#46964

I am guessing they have to wait untill the next HomeAssistant version, or can they still be incorperated in the beta?

[starkillerOG]

Import and user should not raise on progress. Discovery should raise on progress (the default).

Alright, just a moment, I will adjust this

[MartinHjelmare]

I think they can wait for the next cycle.

[MartinHjelmare]

We don't need to adjust anything. The discovery flow has already set unique_id.

[starkillerOG]

@MartinHjelmare yea you are right, stupid of me