Add Xiaomi Miio light config flow#47161
Merged
MartinHjelmare merged 10 commits intoMar 11, 2021
Merged
Conversation
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
|
Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration ( |
8 tasks
Contributor
Author
|
@MartinHjelmare could you also revieuw/merge this PR (since you also did all other Miio config flows)? |
This was referenced Feb 28, 2021
MartinHjelmare
requested changes
Mar 4, 2021
Member
|
Please resolve the merge conflict. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Contributor
Author
|
@MartinHjelmare merge conflict has been resolved. |
Contributor
Author
|
@MartinHjelmare you also already approved this PR, can you also merge this one? |
Member
|
Yes, please solve the merge conflict and I'll merge. |
Contributor
Author
|
@MartinHjelmare just resolved the merge conflict. |
Contributor
Author
|
@MartinHjelmare all tests have passed |
MartinHjelmare
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The Xiaomi Miio Light platform now uses Config Flow, the old yaml config is imported to a Config Entry, please remove the yaml config once you see the
Loading Xiaomi Miio Light via platform setup is deprecated. Please remove it from your configuration.warning in the log.The
brandandbrand_sleepattributes were renamed tobandandband_sleep.Proposed change
Add config flow for the Xiaomi Miio Light platform
Type of change
Example entry for
configuration.yaml:Config flow
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: