Skip to content

Add Xiaomi Miio light config flow#47161

Merged
MartinHjelmare merged 10 commits into
home-assistant:devfrom
starkillerOG:Miio_light_config_flow
Mar 11, 2021
Merged

Add Xiaomi Miio light config flow#47161
MartinHjelmare merged 10 commits into
home-assistant:devfrom
starkillerOG:Miio_light_config_flow

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 28, 2021

Breaking change

The Xiaomi Miio Light platform now uses Config Flow, the old yaml config is imported to a Config Entry, please remove the yaml config once you see the Loading Xiaomi Miio Light via platform setup is deprecated. Please remove it from your configuration. warning in the log.

The brand and brand_sleep attributes were renamed to band and band_sleep.

Proposed change

Add config flow for the Xiaomi Miio Light platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Config flow

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare could you also revieuw/merge this PR (since you also did all other Miio config flows)?

Comment thread homeassistant/components/xiaomi_miio/light.py Outdated
Comment thread homeassistant/components/xiaomi_miio/light.py
@MartinHjelmare
Copy link
Copy Markdown
Member

Please resolve the merge conflict.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare merge conflict has been resolved.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare you also already approved this PR, can you also merge this one?

@MartinHjelmare
Copy link
Copy Markdown
Member

Yes, please solve the merge conflict and I'll merge.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare just resolved the merge conflict.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare all tests have passed

@MartinHjelmare MartinHjelmare merged commit cf4954f into home-assistant:dev Mar 11, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants