Skip to content

Limit log spam by ConfigEntryNotReady #47201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Mar 2, 2021
Merged

Limit log spam by ConfigEntryNotReady #47201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa990de
Limit log spam
chemelli74 Feb 28, 2021
da94197
Changed logic from "wait_time" to "tries"
chemelli74 Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions homeassistant/config_entries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,20 @@ async def async_setup(
self.state = ENTRY_STATE_SETUP_RETRY
wait_time = 2 ** min(tries, 4) * 5
tries += 1
_LOGGER.warning(
"Config entry '%s' for %s integration not ready yet. Retrying in %d seconds",
self.title,
self.domain,
wait_time,
)
if wait_time < 80:

@MartinHjelmare MartinHjelmare Feb 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just log a warning the first time, and let the rest be debug messages?

@chemelli74 chemelli74 Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the suggestion.
Should I word it

"Config entry '%s' for %s integration not ready yet. Retrying in background"

or something similar ?

@MartinHjelmare MartinHjelmare Feb 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. What do you think @balloob?

@chemelli74 chemelli74 Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mean time that we wait for Paulus check, I'll updated the code.

_LOGGER.warning(
"Config entry '%s' for %s integration not ready yet. Retrying in %d seconds",
self.title,
self.domain,
wait_time,
)
elif wait_time == 80:
_LOGGER.warning(
"Config entry '%s' for %s integration not ready yet. Retrying in %d seconds. This is the last logged message.",
self.title,
self.domain,
wait_time,
)

async def setup_again(now: Any) -> None:
"""Run setup again."""
Expand Down