Skip to content

Bump python-vlc-telnet to 2.0.1 #46608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 1 commit into from
Feb 16, 2021
Merged

Bump python-vlc-telnet to 2.0.1 #46608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ homeassistant/components/vicare/* @oischinger
homeassistant/components/vilfo/* @ManneW
homeassistant/components/vivotek/* @HarlemSquirrel
homeassistant/components/vizio/* @raman325
homeassistant/components/vlc_telnet/* @rodripf
homeassistant/components/vlc_telnet/* @rodripf @dmcc
homeassistant/components/volkszaehler/* @fabaff
homeassistant/components/volumio/* @OnFreund
homeassistant/components/waqi/* @andrey-git
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/vlc_telnet/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"domain": "vlc_telnet",
"name": "VLC media player Telnet",
"documentation": "https://www.home-assistant.io/integrations/vlc-telnet",
"requirements": ["python-telnet-vlc==1.0.4"],
"codeowners": ["@rodripf"]
"requirements": ["python-telnet-vlc==2.0.1"],
"codeowners": ["@rodripf", "@dmcc"]
}
9 changes: 4 additions & 5 deletions homeassistant/components/vlc_telnet/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

DEFAULT_NAME = "VLC-TELNET"
DEFAULT_PORT = 4212
MAX_VOLUME = 500

SUPPORT_VLC = (
SUPPORT_PAUSE
Expand Down Expand Up @@ -210,17 +211,15 @@ def mute_volume(self, mute):
"""Mute the volume."""
if mute:
self._volume_bkp = self._volume
self._volume = 0
self._vlc.set_volume("0")
self.set_volume_level(0)
else:
self._vlc.set_volume(str(self._volume_bkp))
self._volume = self._volume_bkp
self.set_volume_level(self._volume_bkp)

self._muted = mute

def set_volume_level(self, volume):
"""Set volume level, range 0..1."""
self._vlc.set_volume(str(volume * 500))
self._vlc.set_volume(volume * MAX_VOLUME)
self._volume = volume

def media_play(self):
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1813,7 +1813,7 @@ python-tado==0.8.1
python-telegram-bot==13.1

# homeassistant.components.vlc_telnet
python-telnet-vlc==1.0.4
python-telnet-vlc==2.0.1

# homeassistant.components.twitch
python-twitch-client==0.6.0
Expand Down