Skip to content

Bump python-vlc-telnet to 2.0.1#46608

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
dmcc:bump-vlc-telnet
Feb 16, 2021
Merged

Bump python-vlc-telnet to 2.0.1#46608
MartinHjelmare merged 1 commit into
home-assistant:devfrom
dmcc:bump-vlc-telnet

Conversation

@dmcc
Copy link
Copy Markdown
Contributor

@dmcc dmcc commented Feb 16, 2021

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Includes corresponding Home Assistant changes to avoid introducing
regressions.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @rodripf, mind taking a look at this pull request as its been labeled with an integration (vlc_telnet) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 16, 2021

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Feb 16, 2021

I've linked a GitHub commit compare of the version bump in the PR description.

It would help the community to track the development of the library if you publish GitHub releases, besides publishing on PyPI. Also consider unlinking the repository from the upstream it was forked from on GitHub. This will make it easier to compare tags and make pull request to the repository. You can contact GitHub support and ask them to do this.

Thanks for your support!

@MartinHjelmare
Copy link
Copy Markdown
Member

Sorry, I realized now that you may not be the maintainer of the library repository.

@MartinHjelmare MartinHjelmare merged commit 713544e into home-assistant:dev Feb 16, 2021
@dmcc dmcc deleted the bump-vlc-telnet branch February 17, 2021 00:51
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants