Add Jellyfin integration#44401
Conversation
|
Hi @j-stienstra, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Isn't the emby integration sufficient? |
|
Jellyfin has forked from Emby around two years ago now and although the Emby integration can at this moment still be used with Jellyfin servers, there is no guarantee it will remain working. Therefore using the jellyfin provided Python API provides a more stable platform to build on. |
|
Thanks for clarifying |
|
@j-stienstra Thanks for this. Feel free to ping me (or the greater Jellyfin team) if you need any assistance (that goes for any HA maintainers too). |
|
@milanmeu, thanks for the review! I rebased my fork and applied the suggested changes to the import and string formats. |
|
Have another look at the comment #44401 (comment). |
|
With #49762 strict type checks are now opt-in. Seems you already annotated everything, please add it to |
|
Thanks! |
|
#49847 renamed |
|
@KapJI Done! I'm getting quite handy at this rebasing by now :) |
Remove connection class from config flow Co-authored-by: Milan Meulemans <milan.meulemans@live.be>
|
There are some build errors. You may need to rebase again and then address the things that are related to this integration. |
|
Sorry about the closing and re-opening. Hit the wrong button in the Github app.... |
Proposed change
Add an integration for Jellyfin media system. The integration provides the content of a user's libraries as a media source with Home Assistant. This initial pull request is intentionally limited in scope, supporting only a single Jellyfin server at a time and supporting only music libraries. This is done to keep this initial submission small.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: