Skip to content

Add Jellyfin logo and icon#2099

Merged
frenck merged 2 commits into
home-assistant:masterfrom
RunC0deRun:jellyfin
Nov 15, 2021
Merged

Add Jellyfin logo and icon#2099
frenck merged 2 commits into
home-assistant:masterfrom
RunC0deRun:jellyfin

Conversation

@RunC0deRun
Copy link
Copy Markdown
Contributor

Proposed change

Add logo and icon for the newly proposed Jellyfin media system integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Dec 21, 2020
frenck
frenck previously approved these changes Dec 21, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Dec 21, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Nov 12, 2021
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 12, 2021

@j-stienstra The parent has been merged, could you resolve the merge conflict here?

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 15, 2021

@j-stienstra The custom_integration assets needs to be removed, the domains collide

@RunC0deRun
Copy link
Copy Markdown
Contributor Author

Yeah, needed to figure that one out. Should be good now.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-stienstra 👍

@frenck frenck merged commit bdcbe62 into home-assistant:master Nov 15, 2021
@RunC0deRun RunC0deRun deleted the jellyfin branch November 15, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaits-parent Awaits the merge of an parent PR cla-signed has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants