Fix validation and use consts (mqtt)#4396
Merged
Merged
Conversation
|
@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @bestlibre and @jaharkes to be potential reviewers. |
Member
|
Looks good! 🐬 |
bestlibre
reviewed
Nov 15, 2016
| @@ -139,8 +138,8 @@ def valid_publish_topic(value): | |||
| # Service call validation schema | |||
| MQTT_PUBLISH_SCHEMA = vol.Schema({ | |||
Contributor
There was a problem hiding this comment.
The Required above was copied from here. Are QOS and RETAIN required here also ? Or could it be set to optional ?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The configuration variables
qosandretainintroduced in #4381 are optional.Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1445
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass