Skip to content

support for last will and birth message for mqtt#4381

Merged
balloob merged 1 commit into
home-assistant:devfrom
bestlibre:mqtt_will_birth
Nov 15, 2016
Merged

support for last will and birth message for mqtt#4381
balloob merged 1 commit into
home-assistant:devfrom
bestlibre:mqtt_will_birth

Conversation

@bestlibre
Copy link
Copy Markdown
Contributor

@bestlibre bestlibre commented Nov 14, 2016 •
edited by balloob
Loading

Description:
This PR is based on work done by @renekliment (PR #1316).

It adds support for last will and birth message for the mqtt platform.

Example entry for configuration.yaml (if applicable):

broker: localhost
port: 1883
client_id: home-assistant
keepalive: 60
username: hass
password: password
birth_message:
  topic: 'hass/status'
  payload: 'online'
  qos: 1
  retain: true
will_message:
  topic: 'hass/status'
  payload: 'offline'
  qos: 1
  retain: true

@mention-bot
Copy link
Copy Markdown

mention-bot commented Nov 14, 2016

@bestlibre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @jaharkes and @timharton to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 15, 2016

Looks good! 🐬

@balloob balloob merged commit 0e0ba28 into home-assistant:dev Nov 15, 2016
@fabaff fabaff mentioned this pull request Nov 15, 2016
Merged
3 tasks
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Nov 15, 2016 •
edited by MartinHjelmare
Loading

Docs update: home-assistant/home-assistant.io#1445

MartinHjelmare
MartinHjelmare reviewed Nov 15, 2016
View reviewed changes
Comment thread homeassistant/components/mqtt/__init__.py
CLIENT_KEY_AUTH_MSG = 'client_key and client_cert must both be present in ' \
'the mqtt broker config'

MQTT_PUBLISH_SCHEMA = vol.Schema({
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to overwrite the service schema with the same name on line 140? I think we should have separate names.

Copy link
Copy Markdown
Contributor Author

@bestlibre bestlibre Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed... I commited the wrong version

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @fabaff can fix this in #4400 ?

Copy link
Copy Markdown
Member

@balloob balloob Nov 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit a fix for this @bestlibre or we'll have to rollback this PR before the next release (Friday).

@MartinHjelmare MartinHjelmare mentioned this pull request Nov 15, 2016
Merged
2 tasks
@bestlibre bestlibre mentioned this pull request Nov 16, 2016
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bestlibre @mention-bot @balloob @fabaff @MartinHjelmare