Skip to content

Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration #42804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springstan merged 2 commits into from
Nov 6, 2020
Merged

Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration #42804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007ae62
Add @soldag to code owners of rpi_gpio_pwm platform
soldag Nov 3, 2020
623f5fb
Remove unneeded state restoration of the physical device in rpi_gpio_…
soldag Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ homeassistant/components/rmvtransport/* @cgtobi
homeassistant/components/roku/* @ctalkington
homeassistant/components/roomba/* @pschmitt @cyr-ius @shenxn
homeassistant/components/roon/* @pavoni
homeassistant/components/rpi_gpio_pwm/* @soldag
homeassistant/components/rpi_power/* @shenxn @swetoast
homeassistant/components/ruckus_unleashed/* @gabe565
homeassistant/components/safe_mode/* @home-assistant/core
Expand Down
4 changes: 0 additions & 4 deletions homeassistant/components/rpi_gpio_pwm/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@ async def async_added_to_hass(self):
self._brightness = last_state.attributes.get(
"brightness", DEFAULT_BRIGHTNESS
)
self._led.set(
is_on=self._is_on, brightness=_from_hass_brightness(self._brightness)
)

@property
def should_poll(self):
Expand Down Expand Up @@ -199,7 +196,6 @@ async def async_added_to_hass(self):
last_state = await self.async_get_last_state()
if last_state:
self._color = last_state.attributes.get("hs_color", DEFAULT_COLOR)
self._led.set(color=_from_hass_color(self._color))

@property
def hs_color(self):
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/rpi_gpio_pwm/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"name": "pigpio Daemon PWM LED",
"documentation": "https://www.home-assistant.io/integrations/rpi_gpio_pwm",
"requirements": ["pwmled==1.6.6"],
"codeowners": []
"codeowners": ["@soldag"]
}