Skip to content

Add missing config flow translation key to script scaffold#42621

Merged
balloob merged 1 commit intohome-assistant:devfrom
allenporter:scaffold
Oct 30, 2020
Merged

Add missing config flow translation key to script scaffold#42621
balloob merged 1 commit intohome-assistant:devfrom
allenporter:scaffold

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Add missing config key for no_url_available when generating new oauth2
config entry based integrations. This was found in issue #42423 where
the nest integration was missing a string when a user had a misconfiguration.

Updating here so that new integrations created by following instructions Creating your first integration will not be hit by the same issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Add missing config key for no_url_available when generating new oauth2
config entry based integrations.  This was found in issue home-assistant#42423 where
the nest integration was missing a string when a user had a misconfiguration.
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit b228ffc into home-assistant:dev Oct 30, 2020
@allenporter allenporter deleted the scaffold branch October 31, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants