Skip to content

Add missing config flow translation key for Nest#42423

Merged
balloob merged 1 commit intodevfrom
frenck-2020-0903
Oct 26, 2020
Merged

Add missing config flow translation key for Nest#42423
balloob merged 1 commit intodevfrom
frenck-2020-0903

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Oct 26, 2020

Proposed change

The OAuth2 configuration flow for the new Nest DSM is missing a translation key, causing a user with no available URLs on their system to get an empty abort dialog.

⚠️ This PR needs to go into 0.117 and this requires translation updates on the rc branch.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @awarecan, @allenporter, mind taking a look at this pull request as its been labeled with an integration (nest) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit ba655c5 into dev Oct 26, 2020
@balloob balloob deleted the frenck-2020-0903 branch October 26, 2020 19:29
allenporter added a commit to allenporter/home-assistant-core that referenced this pull request Oct 30, 2020
Add missing config key for no_url_available when generating new oauth2
config entry based integrations.  This was found in issue home-assistant#42423 where
the nest integration was missing a string when a user had a misconfiguration.
balloob pushed a commit that referenced this pull request Oct 30, 2020
Add missing config key for no_url_available when generating new oauth2
config entry based integrations.  This was found in issue #42423 where
the nest integration was missing a string when a user had a misconfiguration.
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants