Skip to content

Cleanup RainMachine#42544

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bachya:rainmachine-cleanup
Oct 28, 2020
Merged

Cleanup RainMachine#42544
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bachya:rainmachine-cleanup

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Oct 28, 2020

Proposed change

This PR performs some additional RainMachine cleanup (following up on #42241).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 3151893 into home-assistant:dev Oct 28, 2020
tschamm pushed a commit to tschamm/core that referenced this pull request Oct 29, 2020
@bachya bachya deleted the rainmachine-cleanup branch October 29, 2020 15:40
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants