Add options flow to RainMachine#42241
Merged
bachya merged 2 commits intohome-assistant:devfrom Oct 28, 2020
Merged
Conversation
bachya
force-pushed
the
rainmachine-options-flow
branch
2 times, most recently
from
d683c87 to
416ca3d
Compare
bachya
force-pushed
the
rainmachine-options-flow
branch
from
ede6988 to
d5973a2
Compare
| ]: | ||
| hass.services.async_register(DOMAIN, service, method, schema=schema) | ||
|
|
||
| config_entry.add_update_listener(async_reload_entry) |
Member
There was a problem hiding this comment.
We should save the unsubscribe callback returned here and call that on entry unload.
https://developers.home-assistant.io/docs/config_entries_options_flow_handler#signal-updates
| with patch( | ||
| "homeassistant.components.rainmachine.async_setup_entry", return_value=True | ||
| ): | ||
| result = await hass.config_entries.options.async_init(config_entry.entry_id) |
Member
There was a problem hiding this comment.
We need to set up the integration before starting the options flow to make sure that the config flow module is loaded. Otherwise we're relying on the other tests to do that.
Contributor
Author
There was a problem hiding this comment.
The config entry is already set up above (lines 14-20); are you thinking something else?
Member
There was a problem hiding this comment.
I don't see that. We only create a mock config entry and add it to hass. It needs to be set up with hass.config_entries.async_setup.
Thomas55555
pushed a commit
to Thomas55555/core
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds an options flow to RainMachine and adds an appropriate parameter (the default zone runtime) to it.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: