Skip to content

Add device info default values to Panasonic Viera#42441

Merged
balloob merged 1 commit into
home-assistant:devfrom
joogps:panasonic-viera-device-info
Oct 27, 2020
Merged

Add device info default values to Panasonic Viera#42441
balloob merged 1 commit into
home-assistant:devfrom
joogps:panasonic-viera-device-info

Conversation

@joogps
Copy link
Copy Markdown
Contributor

@joogps joogps commented Oct 27, 2020

Proposed change

This pull request derives from #42275, and it includes the addition of default values for the Panasonic Viera media player device info, as well as two extra missing tests for the config flow (also that file is getting wayyyy too big! would there be a way of creating like... test template functions?)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob added this to the 0.117.0 milestone Oct 27, 2020
@balloob balloob merged commit b45ac51 into home-assistant:dev Oct 27, 2020
Comment thread homeassistant/components/panasonic_viera/media_player.py
@joogps joogps deleted the panasonic-viera-device-info branch October 27, 2020 10:45
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panasonic Viera integration error on start up

4 participants