Add remote control platform to Panasonic Viera#42275
Closed
joogps wants to merge 6 commits into
Closed
Conversation
8 tasks
jking95
approved these changes
Oct 24, 2020
Contributor
Author
|
thks @jking95! |
dgomes
reviewed
Oct 24, 2020
Member
|
@joogps would you be able to extract the device info fixes out of this PR and into a new PR which can be included in the upcoming 0.117 release? |
balloob
reviewed
Oct 26, 2020
| return None | ||
| if self._device_info is None: | ||
| return None | ||
| return self._device_info[ATTR_UDN] |
Member
There was a problem hiding this comment.
There is still a UUID in the response by Tom, isn't that the same as UDN ?
Contributor
Author
There was a problem hiding this comment.
actually the problem was that his TV apparently has no model number explicit in the descriptor file
so I just set a bunch of default values in case they can't be found
the unique id was ok (I think)
Contributor
Author
|
@balloob sure! i was actually already kind of planning to do that, haha |
Member
|
Can you do it in the next 24 hours ? Please tag me when you make the PR. |
21 tasks
Contributor
Author
21 tasks
Thomas55555
pushed a commit
to Thomas55555/core
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This pull request adds the
remoteentity to the Panasonic Viera integration (withsend_commandsupport, for both default and custom keys) and defines default manufacturer and model number values, fixing possible future issues with TVs that (for some reason) don't return alldevice_infoproperties (as seen here #42205, thanks @tomlut!). I'm also adding remote tests and two new config flow cases to increase code coverage (maybe I should make separate PRs? 🤔) (that happened)Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: