Skip to content

Reduce domain states rate limit to 1 per second#42004

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:domain_ratelimit
Oct 19, 2020
Merged

Reduce domain states rate limit to 1 per second#42004
balloob merged 1 commit intohome-assistant:devfrom
bdraco:domain_ratelimit

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 17, 2020

Breaking change

#41225 implemented a rate limit of 1 update per minute for states.DOMAIN in templates. This works fine for all states, however it turned out to be too conservative for states.DOMAIN per home-assistant/architecture#449 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 77b95ae into home-assistant:dev Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants