Skip to content

Remove manual rate_limit control directive from templates#41225

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:ratelimit_tweaks
Oct 4, 2020
Merged

Remove manual rate_limit control directive from templates#41225
balloob merged 1 commit intohome-assistant:devfrom
bdraco:ratelimit_tweaks

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 4, 2020

If we want to remove this before 0.116 ships, the breaking changes section in #40667 should be updated as well as the docs. Also #41030 would need to be cherry-picked as well.

Proposed change

Remove manual rate_limit control directive from templates

Increase default rate limit for all states and entire
domain states to one minute

Ensure specifically referenced entities are excluded from
the rate limit

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Increase default rate limit for all states and entire
domain states to one minute

Ensure specifically referenced entities are excluded from
the rate limit
@bdraco
Copy link
Member Author

bdraco commented Oct 4, 2020

We haven't reached a decision on how to deal with time based template updates, and inline template directives may not be the path forward so it makes sense to remove the rate_limit() directive from the template engine in 0.116 until we can decide a path forward.

@balloob balloob added this to the 0.116.0 milestone Oct 4, 2020
@balloob balloob merged commit 51da605 into home-assistant:dev Oct 4, 2020
balloob pushed a commit that referenced this pull request Oct 5, 2020
Increase default rate limit for all states and entire
domain states to one minute

Ensure specifically referenced entities are excluded from
the rate limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants