Skip to content

Merge Tasmota sensor device class and icon maps#41706

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
emontnemery:tasmota_sensor_device_class_icon
Oct 12, 2020
Merged

Merge Tasmota sensor device class and icon maps#41706
MartinHjelmare merged 2 commits into
home-assistant:devfrom
emontnemery:tasmota_sensor_device_class_icon

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Merge Tasmota sensor device class and icon maps.
To address future issues as pointed out here:
#41483 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/tasmota/sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit f70aa0b into home-assistant:dev Oct 12, 2020
@emontnemery emontnemery deleted the tasmota_sensor_device_class_icon branch October 14, 2020 17:49
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants